Magento Coding Standard (PHPCS) report for magekey/module-adc-popup =================================================================== Package version: 2.0.8 | Magento: 2.4.9 | Tested: 2026-05-27 91 warnings in 13 files Helper/Data.php 15:5 warning Visibility must be declared on all constants if your project supports PHP 7.1 or later (PSR12.Properties.ConstantVisibility.NotFound) 20:5 warning Visibility must be declared on all constants if your project supports PHP 7.1 or later (PSR12.Properties.ConstantVisibility.NotFound) 25:5 warning Visibility must be declared on all constants if your project supports PHP 7.1 or later (PSR12.Properties.ConstantVisibility.NotFound) 27:5 warning Visibility must be declared on all constants if your project supports PHP 7.1 or later (PSR12.Properties.ConstantVisibility.NotFound) 29:5 warning Visibility must be declared on all constants if your project supports PHP 7.1 or later (PSR12.Properties.ConstantVisibility.NotFound) 31:5 warning Visibility must be declared on all constants if your project supports PHP 7.1 or later (PSR12.Properties.ConstantVisibility.NotFound) 36:5 warning Visibility must be declared on all constants if your project supports PHP 7.1 or later (PSR12.Properties.ConstantVisibility.NotFound) CustomerData/Popup.php 99:8 warning If the @inheritdoc not inline it shouldn’t have braces (Magento2.Annotation.MethodAnnotationStructure.MethodAnnotation) 155:40 warning array_merge(...) is used in a loop and is a resources greedy construction. (Magento2.Performance.ForeachArrayMerge.ForeachArrayMerge) CustomerData/ItemPoolPlugin.php 35:5 warning Missing short description (Magento2.Annotation.MethodAnnotationStructure.MethodAnnotation) 36:8 warning There must be exactly one blank line before tags (Magento2.Annotation.MethodAnnotationStructure.MethodAnnotation) 40:12 warning Missing @param for argument in method annotation (Magento2.Annotation.MethodArguments.ParamMissing) Model/Storage.php 13:5 warning Visibility must be declared on all constants if your project supports PHP 7.1 or later (PSR12.Properties.ConstantVisibility.NotFound) 15:5 warning Visibility must be declared on all constants if your project supports PHP 7.1 or later (PSR12.Properties.ConstantVisibility.NotFound) Model/Config/Source/CategoryList.php 26:5 warning Missing short description (Magento2.Annotation.MethodAnnotationStructure.MethodAnnotation) 27:8 warning There must be exactly one blank line before tags (Magento2.Annotation.MethodAnnotationStructure.MethodAnnotation) 51:28 warning The use of function html_entity_decode() is discouraged (Magento2.Functions.DiscouragedFunction.Discouraged) 55:28 warning array_merge(...) is used in a loop and is a resources greedy construction. (Magento2.Performance.ForeachArrayMerge.ForeachArrayMerge) Model/Config/Source/FetchType.php 10:5 warning Missing short description (Magento2.Annotation.MethodAnnotationStructure.MethodAnnotation) 11:8 warning There must be exactly one blank line before tags (Magento2.Annotation.MethodAnnotationStructure.MethodAnnotation) Observer/QuoteAddAfter.php 29:5 warning Missing short description (Magento2.Annotation.MethodAnnotationStructure.MethodAnnotation) 30:8 warning There must be exactly one blank line before tags (Magento2.Annotation.MethodAnnotationStructure.MethodAnnotation) 32:12 warning Missing @param for argument in method annotation (Magento2.Annotation.MethodArguments.ParamMissing) Observer/CartAddComplete.php 39:5 warning Missing short description (Magento2.Annotation.MethodAnnotationStructure.MethodAnnotation) 40:8 warning There must be exactly one blank line before tags (Magento2.Annotation.MethodAnnotationStructure.MethodAnnotation) 42:12 warning Missing @param for argument in method annotation (Magento2.Annotation.MethodArguments.ParamMissing) etc/frontend/events.xml 1:1 warning End of line character is invalid; expected "\n" but found "\r\n" (Generic.Files.LineEndings.InvalidEOLChar) view/frontend/templates/popup.phtml 16:85 warning Unescaped output detected. (Magento2.Security.XssTemplate.FoundNotAllowed) 16:125 warning Line exceeds 120 characters; contains 125 characters (Generic.Files.LineLength.TooLong) view/frontend/web/template/cart/item.html 1:1 warning Avoid using closing slash with void tags, this can lead to unexpected behavior - "" (Magento2.Html.HtmlClosingVoidTags.HtmlClosingVoidElements) view/frontend/web/css/source/_module.less 46:1 warning Selector contains uppercase symbols (Magento2.Less.TypeSelectors.UpperCaseSelector) 46:1 warning CSS class name does not follow class naming requirements: APIW (Magento2.Less.ClassNaming.NotAllowedSymbol) 46:1 warning CSS class names should be separated with "-" (dash) instead of "_" (underscore) (Magento2.Less.ClassNaming.NotAllowedSymbol) 46:44 warning Add a line break after each selector delimiter (Magento2.Less.SelectorDelimiter.LineBreakAfterDelimiter) 49:5 warning CSS class name does not follow class naming requirements: APINC (Magento2.Less.ClassNaming.NotAllowedSymbol) 49:5 warning CSS class names should be separated with "-" (dash) instead of "_" (underscore) (Magento2.Less.ClassNaming.NotAllowedSymbol) 52:1 warning Selector contains uppercase symbols (Magento2.Less.TypeSelectors.UpperCaseSelector) 52:1 warning CSS class name does not follow class naming requirements: APINC (Magento2.Less.ClassNaming.NotAllowedSymbol) 52:1 warning CSS class names should be separated with "-" (dash) instead of "_" (underscore) (Magento2.Less.ClassNaming.NotAllowedSymbol) 52:47 warning Add a line break after each selector delimiter (Magento2.Less.SelectorDelimiter.LineBreakAfterDelimiter) 53:18 warning Space before opening brace is missing (Magento2.Less.BracesFormatting.SpacingBeforeOpen) 53:26 warning Expected 0 blank lines before closing brace of class definition; -1 found (Magento2.Less.BracesFormatting.SpacingBeforeClose) 53:32 warning Space before opening brace is missing (Magento2.Less.BracesFormatting.SpacingBeforeOpen) 53:40 warning Expected 0 blank lines before closing brace of class definition; -1 found (Magento2.Less.BracesFormatting.SpacingBeforeClose) 66:22 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 74:38 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 78:52 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 86:55 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 92:46 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 101:95 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 120:66 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 130:100 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 146:54 warning Values starts from "0" (Magento2.Less.ZeroUnits.ZeroUnitFound) 153:63 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 162:58 warning Add a line break after each selector delimiter (Magento2.Less.SelectorDelimiter.LineBreakAfterDelimiter) 166:62 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 177:106 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 181:105 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 188:51 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 222:58 warning Values starts from "0" (Magento2.Less.ZeroUnits.ZeroUnitFound) 238:50 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 242:62 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 263:48 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 271:32 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 288:87 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 291:38 warning Values starts from "0" (Magento2.Less.ZeroUnits.ZeroUnitFound) 299:48 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 304:47 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 307:41 warning Values starts from "0" (Magento2.Less.ZeroUnits.ZeroUnitFound) 343:32 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 348:86 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 356:39 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 369:51 warning Properties sorted not alphabetically (Magento2.Less.PropertiesSorting.PropertySorting) 383:25 warning CSS class name does not follow class naming requirements: APINC (Magento2.Less.ClassNaming.NotAllowedSymbol) 383:25 warning CSS class names should be separated with "-" (dash) instead of "_" (underscore) (Magento2.Less.ClassNaming.NotAllowedSymbol) 384:25 warning CSS class name does not follow class naming requirements: APIW (Magento2.Less.ClassNaming.NotAllowedSymbol) 384:25 warning CSS class names should be separated with "-" (dash) instead of "_" (underscore) (Magento2.Less.ClassNaming.NotAllowedSymbol) 401:25 warning CSS class name does not follow class naming requirements: APINC (Magento2.Less.ClassNaming.NotAllowedSymbol) 401:25 warning CSS class names should be separated with "-" (dash) instead of "_" (underscore) (Magento2.Less.ClassNaming.NotAllowedSymbol) 402:25 warning CSS class name does not follow class naming requirements: APIW (Magento2.Less.ClassNaming.NotAllowedSymbol) 402:25 warning CSS class names should be separated with "-" (dash) instead of "_" (underscore) (Magento2.Less.ClassNaming.NotAllowedSymbol) 423:25 warning CSS class name does not follow class naming requirements: APIW (Magento2.Less.ClassNaming.NotAllowedSymbol) 423:25 warning CSS class names should be separated with "-" (dash) instead of "_" (underscore) (Magento2.Less.ClassNaming.NotAllowedSymbol) 440:25 warning CSS class name does not follow class naming requirements: APIW (Magento2.Less.ClassNaming.NotAllowedSymbol) 440:25 warning CSS class names should be separated with "-" (dash) instead of "_" (underscore) (Magento2.Less.ClassNaming.NotAllowedSymbol) view/adminhtml/web/css/source/_module.less 6:1 warning Selector contains uppercase symbols (Magento2.Less.TypeSelectors.UpperCaseSelector) 6:1 warning CSS class name does not follow class naming requirements: MKL (Magento2.Less.ClassNaming.NotAllowedSymbol) 19:14 warning Style definitions must end with a semicolon (Magento2.Less.SemicolonSpacing.NotAtEnd) 20:17 warning CSS class name does not follow class naming requirements: MKL (Magento2.Less.ClassNaming.NotAllowedSymbol) 21:1 warning Line indented incorrectly; expected 16 spaces, found 20 (Magento2.Less.Indentation.Incorrect) 22:1 warning Line indented incorrectly; expected 16 spaces, found 20 (Magento2.Less.Indentation.Incorrect)